-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add onnx-subgraph baseline code #14593
base: master
Are you sure you want to change the base?
Conversation
@chenyx113 , there are too many files to review. |
@seanshpark Thanks for suggestion, because it is the first time uploading for the whole project, so it have many files. I understand it is difficult to review so many files at one PR. but if split it to small changes, it will take many PRs for this submitting, is there any other suggestions for baseline code merge? |
@seanshpark step 2 will have more files, and other steps will be simple, hope for your opinion. Thanks & BR |
I don't know the details of the plan. The basic rule is to put single context of changes and not much (not more than 50 lines) to review or your PR will have too many comments that will not be appropriate for you and the reviewers to communicate. |
Q) is current PR has full changes? or is it a part ? |
@seanshpark |
single context of changes
related issue of: #14534
historical draft PR: #14563
Thanks for the review and good suggestions, I have updated the code as last review comments:
please help review, any suggestions and comments will be appreciated, thank you!